refactor: expose DatanodeBuilder::build_object_store_manager() and MitoConfig::sanitize()
#4212
Conversation
zyy17
requested review from
evenyag,
v0y4g3r,
waynexia and
a team
as code owners
|
Warning Rate limit exceeded@zyy17 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 45 minutes and 4 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates introduce a new constant, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- src/common/config/src/lib.rs (1 hunks)
- src/datanode/src/config.rs (2 hunks)
- src/datanode/src/datanode.rs (4 hunks)
- src/mito2/src/config.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- src/common/config/src/lib.rs
Additional comments not posted (3)
src/datanode/src/config.rs (1)
72-72: Standardized default data directory.The change to use
common_config::DEFAULT_DATA_HOMEfor thedata_homefield inStorageConfigis a positive step towards consistency across configurations. This ensures that all components of the system default to the same directory unless explicitly overridden.src/mito2/src/config.rs (1)
301-301: Set robust default for intermediate index storage path.Setting the
intermediate_pathinInvertedIndexConfigto a default value usingjoin_dirfunction ensures that there is always a valid directory specified. This change prevents potential runtime errors and simplifies configuration by providing sensible defaults.src/datanode/src/datanode.rs (1)
273-285: Refactored and exposedbuild_object_store_manager.The refactoring to make
build_object_store_manageran asynchronous function that is publicly accessible is a crucial improvement. It allows for more flexible and dynamic construction ofObjectStoreManagerinstances based on runtime configuration. This change aligns with modern asynchronous programming practices in Rust and enhances modularity.
zyy17
force-pushed
the
refactor/expose-api-for-object-store-manager
branch
from
59462b5
to
b51d8bf
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- config/config.md (2 hunks)
- config/datanode.example.toml (1 hunks)
- config/standalone.example.toml (1 hunks)
- src/common/config/src/lib.rs (1 hunks)
- src/datanode/src/config.rs (2 hunks)
- src/mito2/src/config.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- config/standalone.example.toml
Files skipped from review as they are similar to previous changes (3)
- src/common/config/src/lib.rs
- src/datanode/src/config.rs
- src/mito2/src/config.rs
Additional context used
LanguageTool
config/config.md
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~40-~40: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~49-~49: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[grammar] ~93-~93: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~94-~94: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[uncategorized] ~108-~108: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: .... If not set, it's default to 1/8 of OS memory with a max limitation of 1GB. | | `regi...
[style] ~134-~134: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~143-~143: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~187-~187: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~196-~196: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[style] ~220-~220: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~229-~229: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[style] ~282-~282: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~291-~291: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |runtime| -- | -- | The runtime ...
[grammar] ~373-~373: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~374-~374: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[uncategorized] ~388-~388: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: .... If not set, it's default to 1/8 of OS memory with a max limitation of 1GB. | | `regi...
[style] ~414-~414: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~423-~423: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
Markdownlint
config/config.md
5-5: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
6-6: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
7-7: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
151-151: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
237-237: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
299-299: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
37-37: null (MD034, no-bare-urls)
Bare URL used
184-184: null (MD034, no-bare-urls)
Bare URL used
246-246: null (MD034, no-bare-urls)
Bare URL used
Additional comments not posted (2)
config/datanode.example.toml (1)
419-419: Proper setting of defaultintermediate_pathThe update to set a default value for
intermediate_pathis a positive change. It ensures that the system has a valid directory to operate even if the user does not specify one. This prevents potential runtime errors and aligns with the goal of robustness in system configuration.config/config.md (1)
126-126: Updated default value forintermediate_pathis well-documented.The change in the default value for
intermediate_pathfrom an empty string to/tmp/greptimedb/index_intermediate/is correctly documented here. This aligns with the PR's objective to prevent failures whenopen_compaction_region()is used with the default configuration.
zyy17
force-pushed
the
refactor/expose-api-for-object-store-manager
branch
from
b51d8bf
to
826befa
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
config/config.md (1)
Line range hint
151-151: Remove extra blank lines to adhere to Markdown standards.There are multiple consecutive blank lines that do not adhere to Markdown best practices and can be cleaned up for better readability.
-Also applies to: 237-237, 299-299
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- config/config.md (2 hunks)
- config/datanode.example.toml (1 hunks)
- config/standalone.example.toml (1 hunks)
- src/common/config/src/lib.rs (1 hunks)
- src/datanode/src/config.rs (2 hunks)
- src/mito2/src/config.rs (1 hunks)
- tests-integration/tests/http.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- tests-integration/tests/http.rs
Files skipped from review as they are similar to previous changes (5)
- config/datanode.example.toml
- config/standalone.example.toml
- src/common/config/src/lib.rs
- src/datanode/src/config.rs
- src/mito2/src/config.rs
Additional context used
LanguageTool
config/config.md
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~40-~40: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~49-~49: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[grammar] ~93-~93: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~94-~94: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[style] ~134-~134: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~143-~143: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~187-~187: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~196-~196: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[style] ~220-~220: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~229-~229: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[style] ~282-~282: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~291-~291: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |runtime| -- | -- | The runtime ...
[grammar] ~373-~373: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~374-~374: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[style] ~414-~414: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~423-~423: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
Markdownlint
config/config.md
5-5: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
6-6: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
7-7: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
151-151: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
237-237: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
299-299: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
37-37: null (MD034, no-bare-urls)
Bare URL used
184-184: null (MD034, no-bare-urls)
Bare URL used
246-246: null (MD034, no-bare-urls)
Bare URL used
Additional comments not posted (1)
config/config.md (1)
126-126: Enhance clarity in the description of the default value forintermediate_path.The documentation correctly reflects the new default value for
intermediate_path. However, to enhance clarity, consider specifying that this path is used for storing intermediate files during external sorting operations, as this detail enhances user understanding of the configuration's purpose.- File system path to store intermediate files for external sorting (default `{data_home}/index_intermediate`). + File system path to store intermediate files during external sorting operations. Default is `{data_home}/index_intermediate`.
zyy17
force-pushed
the
refactor/expose-api-for-object-store-manager
branch
from
826befa
to
2256eb1
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- config/config.md (2 hunks)
- config/datanode.example.toml (1 hunks)
- config/standalone.example.toml (1 hunks)
- src/common/config/src/lib.rs (1 hunks)
- src/datanode/src/config.rs (2 hunks)
- src/mito2/src/config.rs (1 hunks)
- tests-integration/tests/http.rs (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- config/datanode.example.toml
- config/standalone.example.toml
- src/common/config/src/lib.rs
- src/datanode/src/config.rs
- src/mito2/src/config.rs
- tests-integration/tests/http.rs
Additional context used
LanguageTool
config/config.md
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~31-~31: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~40-~40: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~49-~49: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[grammar] ~93-~93: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~94-~94: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[style] ~134-~134: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~143-~143: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~178-~178: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |mysql| -- | -- | MySQL server o...
[uncategorized] ~187-~187: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |postgres| -- | -- | PostgresSQL ...
[uncategorized] ~196-~196: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload | |opentsdb| -- | -- | OpenTSDB pro...
[style] ~220-~220: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~229-~229: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[style] ~282-~282: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~291-~291: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...for Certificate and key file change and auto reload.
For now, gRPC tls config does not ...
[uncategorized] ~325-~325: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’). (AUTO_HYPHEN)
Context: ...r now, gRPC tls config does not support auto reload. | |runtime| -- | -- | The runtime ...
[grammar] ~373-~373: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...e| String |None` | The scope of the google cloud storage.
**It's only used whe...
[grammar] ~374-~374: “Google” is a proper noun and needs to be capitalized. (A_GOOGLE)
Context: ...g |None| The credential path of the google cloud storage.
**It's only used whe...
[style] ~414-~414: To form a complete sentence, be sure to include a subject. (MISSING_IT_THERE)
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...
[grammar] ~423-~423: Consider using either the past participle “recommended” or the present participle “recommending” here. (BEEN_PART_AGREEMENT)
Context: ...Forstandalonemode,self_importis recommend to collect metrics generated by itself ...
Markdownlint
config/config.md
5-5: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
6-6: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
7-7: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
151-151: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
237-237: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
299-299: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
37-37: null (MD034, no-bare-urls)
Bare URL used
184-184: null (MD034, no-bare-urls)
Bare URL used
246-246: null (MD034, no-bare-urls)
Bare URL used
Additional comments not posted (1)
config/config.md (1)
126-126: Default Path for Intermediate Files Correctly SetThe new default path for
intermediate_pathis consistently set across different configurations to/tmp/greptimedb/index_intermediate/. This change ensures that there are no failures due to an empty path value and standardizes file storage paths across the system.Also applies to: 406-406
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4212 +/- ##
==========================================
- Coverage 84.86% 84.58% -0.29%
==========================================
Files 1045 1045
Lines 184251 184250 -1
==========================================
- Hits 156373 155850 -523
- Misses 27878 28400 +522 |
zyy17
force-pushed
the
refactor/expose-api-for-object-store-manager
branch
from
2256eb1
to
f2213b8
Compare
zyy17
changed the title
build_object_store_manager() and fix empty intermediate_path errorDatanodeBuilder::build_object_store_manager() and MitoConfig::sanitize()
zyy17
force-pushed
the
refactor/expose-api-for-object-store-manager
branch
from
f2213b8
to
ff46a5a
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Some minor refactoring:
Expose
DatanodeBuilder::build_object_store_manager()The scenario is the following code:
Expose
MitoConfig::sanitize()to initialize Mito config outside the crate;2. Set default value forintermediate_pathinstead of empty value(it will failed to create a access layer if usingopen_compaction_region()with default Mito config) (cc @zhongzc);Checklist
Summary by CodeRabbit
New Features
Documentation
Configuration