Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update centos yum source and specify cargo-binstall version #4248

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Jul 2, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Resolve #4242

  1. Use vault.centos.org as default yum for centos:7 image since CentOS 7 has reached EOL since 2024-07-01 thus mirror.centos.org is no longer available;
  2. Specify the installed version of cargo-binstall to adapt current rust toolchain;

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Summary by CodeRabbit

  • Chores
    • Updated CentOS 7 Dockerfiles to use vault.centos.org due to EOL of CentOS 7.
    • Updated Ubuntu Dockerfiles to install cargo-binstall with version 1.6.6 to ensure compatibility with the current Rust toolchain and prevent errors related to unstable library features.

@zyy17 zyy17 requested a review from a team as a code owner July 2, 2024 08:02
Copy link
Contributor

coderabbitai bot commented Jul 2, 2024

Walkthrough

This update focuses on addressing the end-of-life (EOL) of CentOS 7 by switching package repositories from mirror.centos.org to vault.centos.org. Additionally, to ensure compatibility with the current Rust toolchain, specific versions of cargo-binstall are installed across various Dockerfiles. These improvements aim to mitigate build failures, especially noting the recent workflow failure in the GreptimeDB Nightly Build.

Changes

File(s) Change Summary
docker/ci/centos/Dockerfile Switched package repository from mirror.centos.org to vault.centos.org due to CentOS 7 EOL.
docker/dev-builder/centos/Dockerfile Updated package repository to vault.centos.org and fixed Rust toolchain error by pinning cargo-binstall version.
docker/dev-builder/ubuntu/Dockerfile, docker/dev-builder/ubuntu/Dockerfile-18.10 Installed cargo-binstall version 1.6.6 to avoid Rust toolchain errors.

Assessment against linked issues

Objective Addressed Explanation
Ensure CentOS 7 Dockerfiles use the correct repository (#4242)
Fix Rust toolchain errors by installing a specific version of cargo-binstall (#4242)

Poem

Amidst the code where problems reside,
Changes ventured, far and wide.
Swapping mirrors, catching fall,
CentOS now stands tall.
Rust's bins aligned, no more fear,
Nightly builds are crystal clear.
With these fixes, cheer we bring,
Hopping on, let progress sing.


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 2, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2c08b8 and 62e69f8.

Files selected for processing (4)
  • docker/ci/centos/Dockerfile (1 hunks)
  • docker/dev-builder/centos/Dockerfile (2 hunks)
  • docker/dev-builder/ubuntu/Dockerfile (1 hunks)
  • docker/dev-builder/ubuntu/Dockerfile-18.10 (1 hunks)
Files skipped from review due to trivial changes (1)
  • docker/ci/centos/Dockerfile
Additional comments not posted (4)
docker/dev-builder/centos/Dockerfile (2)

5-7: LGTM! Update to vault.centos.org is necessary and correctly implemented.

The update to use vault.centos.org instead of mirror.centos.org is necessary due to CentOS 7 reaching its end-of-life. The sed commands correctly update the URLs in the yum repo files.


33-35: LGTM! Specifying cargo-binstall version ensures compatibility.

Installing cargo-binstall with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.

docker/dev-builder/ubuntu/Dockerfile-18.10 (1)

46-48: LGTM! Specifying cargo-binstall version ensures compatibility.

Installing cargo-binstall with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.

docker/dev-builder/ubuntu/Dockerfile (1)

58-60: LGTM! Specifying cargo-binstall version ensures compatibility.

Installing cargo-binstall with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.

@zyy17 zyy17 requested review from v0y4g3r, evenyag, waynexia and tisonkun and removed request for a team July 2, 2024 09:29
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit ef5d1a6 Jul 2, 2024
22 of 23 checks passed
@evenyag evenyag deleted the ci/use-vault-centos-yum branch July 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow run 'GreptimeDB Nightly Build' failed
3 participants