feat(fuzz): enhance condition check of region migration finish #4283
Conversation
WalkthroughThe updates in this change set involve additions and modifications to the migration logic, including functions for handling partitions and procedures asynchronously. New functions Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant MigrationLogic as Migration Logic
participant DB as Database
participant Utils as Utils
Client->>MigrationLogic: InitiateMigration()
MigrationLogic->>DB: query(region_id)
DB-->>MigrationLogic: return region details
MigrationLogic->>Utils: fetch_partition(region_id)
Utils->>DB: SQL query to fetch partition
DB-->>Utils: return Partition
Utils-->>MigrationLogic: Partition result
MigrationLogic->>DB: execute migration steps
MigrationLogic->>Utils: wait_for_procedure_finish(procedure_id)
Utils->>DB: query procedure_state(procedure_id)
DB-->>Utils: return procedure state
Utils-->>MigrationLogic: procedure state
MigrationLogic-->>Client: Migration completed
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
WenyXu
force-pushed
the
fix/enhance-condition-check
branch
from
f7c75b1
to
cda9f86
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
tests-fuzz/src/utils/procedure.rs (2)
Line range hint
25-32:
Improve error handling.Avoid using
unwrapfor error handling as it can cause the program to panic. Consider using?to propagate errors or handling them appropriately.- let result = sqlx::query(&sql) - .fetch_one(e) - .await - .context(error::ExecuteQuerySnafu { sql }) - .unwrap(); - result.try_get(0).unwrap() + let result = sqlx::query(&sql) + .fetch_one(e) + .await + .context(error::ExecuteQuerySnafu { sql })?; + result.try_get(0).context(error::ExecuteQuerySnafu { sql })
Line range hint
35-53:
Improve error handling and avoid unnecessary cloning.Avoid using
unwrapfor error handling as it can cause the program to panic. Consider using?to propagate errors or handling them appropriately. Additionally, avoid unnecessary cloning ofprocedure_id.- wait_condition_fn( - timeout, - || { - let greptime = greptime.clone(); - let procedure_id = procedure_id.clone(); - Box::pin(async move { procedure_state(&greptime, &procedure_id).await }) - }, - |output| { - info!("Procedure({procedure_id}) state: {:?}", output); - output.to_lowercase().contains("done") - }, - Duration::from_secs(5), - ) - .await + wait_condition_fn( + timeout, + || { + let greptime = greptime.clone(); + Box::pin(async move { procedure_state(&greptime, procedure_id).await }) + }, + |output| { + info!("Procedure({procedure_id}) state: {:?}", output); + output.to_lowercase().contains("done") + }, + Duration::from_secs(5), + ) + .await .context(error::ExecuteQuerySnafu { sql })
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- tests-fuzz/src/utils/partition.rs (1 hunks)
- tests-fuzz/src/utils/procedure.rs (2 hunks)
- tests-fuzz/targets/migration/fuzz_migrate_mito_regions.rs (3 hunks)
Additional comments not posted (1)
tests-fuzz/src/utils/partition.rs (1)
58-75: Improve error handling.Avoid using
unwrapfor error handling as it can cause the program to panic. Consider using?to propagate errors or handling them appropriately.- sqlx::query_as::<_, Partition>(sql) - .bind(region_id) - .fetch_one(e) - .await - .context(error::ExecuteQuerySnafu { sql }) - .unwrap() + sqlx::query_as::<_, Partition>(sql) + .bind(region_id) + .fetch_one(e) + .await + .context(error::ExecuteQuerySnafu { sql })Likely invalid or redundant comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4283 +/- ##
==========================================
- Coverage 84.96% 84.69% -0.27%
==========================================
Files 1058 1058
Lines 188059 188126 +67
==========================================
- Hits 159789 159338 -451
- Misses 28270 28788 +518 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
check the migration result instead of check procedure state
Checklist
Summary by CodeRabbit
New Features
Improvements