-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance ColumnOption::DefaultValue formatting for string values #4287
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests-fuzz/src/ir/create_expr.rs (1 hunks)
Additional comments not posted (1)
tests-fuzz/src/ir/create_expr.rs (1)
42-47
: LGTM! The formatting enhancement for string values is correct.The new implementation correctly formats
Value::String
with single quotes. This change aligns with the PR's objective to enhance the formatting ofColumnOption::DefaultValue
for string values.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
==========================================
- Coverage 84.96% 84.69% -0.28%
==========================================
Files 1061 1061
Lines 188124 188127 +3
==========================================
- Hits 159845 159336 -509
- Misses 28279 28791 +512 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Enhance ColumnOption::DefaultValue formatting for string values, to fix incorrect CreateTableExpr generation🥲
Checklist
Summary by CodeRabbit