refactor: do not print error log on PlanQuery error

[sunng87]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

We get a lot of error logs for "table not found" query on the production. Here I moved PlanQuery code to non error log section to avoid this. I also want to confirm if PlanQuery is all caused by user input errors, which is safe to do so.

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

Summary by CodeRabbit

• Bug Fixes
  • Adjusted internal handling of StatusCode::PlanQuery to improve error management.

[coderabbitai]

Walkthrough

The recent adjustments to the StatusCode enum in src/common/error/src/status_code.rs involve re-organizing the StatusCode::PlanQuery variant within match arms. Specifically, StatusCode::PlanQuery was removed from one match arm and added to another, likely to better reflect the intended logical groupings or error handling behavior.

Changes

File Path	Change Summary
src/common/error/src/status_code.rs	Adjusted placement of StatusCode::PlanQuery in match arms.

Poem

In code, a shuffle we do,
The enums dance, their places new.
From one arm to the next, they glide,
In code's embrace, they now reside.
With PlanQuery shifted, errors align,
Our software's flow now more refined. ⌨️✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f1d17a8 and edba7b8.

Files selected for processing (1)

• src/common/error/src/status_code.rs (2 hunks)

Additional comments not posted (2)

src/common/error/src/status_code.rs (2)

173-173: Verify if PlanQuery errors should not be logged.

The StatusCode::PlanQuery variant has been moved to a match arm that returns false in the should_log_error method. Ensure that all PlanQuery errors are user input errors and do not need error logging to avoid missing critical issues.

---

173-173: Verify if PlanQuery errors should be retryable.

The StatusCode::PlanQuery variant has been moved to a match arm that returns true in the is_retryable method. Ensure that PlanQuery errors are indeed retryable and this change aligns with the intended error handling strategy.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (d1f1fad) to head (edba7b8).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
- Coverage   85.15%   84.88%   -0.28%     
==========================================
  Files        1061     1061              
  Lines      188255   188247       -8     
==========================================
- Hits       160313   159796     -517     
- Misses      27942    28451     +509     

[evenyag]

LGTM

[evenyag]

@waynexia PTAL