Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimizing pipeline performance #4390

Merged
merged 32 commits into from
Aug 13, 2024
Merged

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Jul 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

There are over a thousand lines of code that are test data and benchmarks can be ignored.
src/pipeline/benches/data.log is test data. and src/pipeline/benches/processor.rs is benchmark.

  • Optimizing the performance of type conversions
  • Use Arc clone instead of String clone
  • Passing Intermediate State Using Variable References
  • add an bench
  • Optimize hash get overconsumption by changing the pipeline's intermediate state to vec
  • Both timeindex and timestamp are supported to specify the timeindex in the transform.

Original pipeline workflow

pipeline_original

Current pipeline workflow

pipeline_current

In the original method, there is a lot of data allocation and drop, and a lot of hash get operations. By converting the data into a vector, hash get operations are avoided. And the same batch of data share a common intermediate state. After testing, the performance of the same pipeline processing the same data is improved by more than 30%.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 18, 2024
@paomian paomian force-pushed the feat/pp-vec-v1 branch 9 times, most recently from 4098a98 to cf299cb Compare July 25, 2024 07:46
@paomian paomian marked this pull request as ready for review July 25, 2024 07:47
@paomian paomian requested a review from a team as a code owner July 25, 2024 07:47
@paomian paomian changed the title Feat/pp vec v1 enhance(log): Optimizing pipeline performance Jul 25, 2024
@paomian paomian changed the title enhance(log): Optimizing pipeline performance enhance: Optimizing pipeline performance Jul 25, 2024
@paomian paomian changed the title enhance: Optimizing pipeline performance perf: Optimizing pipeline performance Jul 25, 2024
src/servers/src/http/event.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments for the purpose of the newly added fields and methods, like

processors.output_keys();
processors.required_keys();
processors.required_original_keys();
transforms.required_keys();

src/servers/src/http/event.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl/transform/index.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl/processor.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 74.52019% with 385 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (216bce6) to head (c34c92f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
- Coverage   84.95%   84.64%   -0.31%     
==========================================
  Files        1091     1091              
  Lines      194496   195587    +1091     
==========================================
+ Hits       165229   165559     +330     
- Misses      29267    30028     +761     

src/servers/src/http/event.rs Show resolved Hide resolved
src/pipeline/src/etl.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl.rs Show resolved Hide resolved
@killme2008
Copy link
Contributor

I think we must deliver this PR in v0.9.1, so please take a look @sunng87 @shuiyisong @zhongzc

src/pipeline/benches/processor.rs Show resolved Hide resolved
src/pipeline/src/etl/transform/index.rs Outdated Show resolved Hide resolved
src/pipeline/src/etl.rs Show resolved Hide resolved
src/pipeline/src/etl/processor.rs Show resolved Hide resolved
src/pipeline/src/etl/processor.rs Show resolved Hide resolved
src/pipeline/src/etl/processor.rs Show resolved Hide resolved
src/pipeline/src/etl/processor/letter.rs Show resolved Hide resolved
src/pipeline/src/etl/processor/regex.rs Show resolved Hide resolved
src/pipeline/src/etl/transform/index.rs Outdated Show resolved Hide resolved
src/pipeline/tests/pipeline.rs Outdated Show resolved Hide resolved
@paomian paomian enabled auto-merge August 13, 2024 11:08
@paomian paomian added this pull request to the merge queue Aug 13, 2024
Merged via the queue into GreptimeTeam:main with commit 202c730 Aug 13, 2024
32 checks passed
@paomian paomian deleted the feat/pp-vec-v1 branch August 13, 2024 11:52
CookiePieWw pushed a commit to CookiePieWw/greptimedb that referenced this pull request Sep 17, 2024
* chore: improve pipeline performance

* chore: use arc to improve time type

* chore: improve pipeline coerce

* chore: add vec refactor

* chore: add vec pp

* chore: improve pipeline

* inprocess

* chore: set log ingester use new pipeline

* chore: fix some error by pr comment

* chore: fix typo

* chore: use enum_dispatch to simplify code

* chore: some minor fix

* chore: format code

* chore: update by pr comment

* chore: fix typo

* chore: make clippy happy

* chore: fix by pr comment

* chore: remove epoch and date process add new timestamp process

* chore: add more test for pipeline

* chore: restore epoch and date processor

* chore: compatibility issue

* chore: fix by pr comment

* chore: move the evaluation out of the loop

* chore: fix by pr comment

* chore: fix dissect output key filter

* chore: fix transform output greptime value has order error

* chore: keep pipeline transform output order

* chore: revert tests

* chore: simplify pipeline prepare implementation

* chore: add test for timestamp pipelin processor

* chore: make clippy happy

* chore: replace is_some check to match

---------

Co-authored-by: shuiyisong <xixing.sys@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants