Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new kafka topic consumer respecting WAL index #4424

Merged
merged 16 commits into from
Aug 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jul 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4385

What's changed and what's your intention?

Implement a Kafka Topic Consumer that respects the WAL index info, aim to reduce the read amplification factor during replaying single region.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from v0y4g3r and a team as code owners July 24, 2024 09:02
Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 24, 2024
@WenyXu WenyXu requested a review from fengjiachun July 24, 2024 09:02
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 95.60878% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (1895a54) to head (c5291c4).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4424      +/-   ##
==========================================
- Coverage   84.88%   84.67%   -0.21%     
==========================================
  Files        1081     1084       +3     
  Lines      192961   193725     +764     
==========================================
+ Hits       163799   164041     +242     
- Misses      29162    29684     +522     

src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/consumer.rs Show resolved Hide resolved
src/log-store/src/kafka/consumer.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/util/range.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/consumer.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/consumer.rs Show resolved Hide resolved
src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Jul 31, 2024

@fengjiachun @v0y4g3r PTAL

src/log-store/src/kafka/index.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/util/range.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/util/range.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/util/range.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/consumer.rs Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@fengjiachun
Copy link
Collaborator

@v0y4g3r PTAL

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Aug 5, 2024
Merged via the queue into GreptimeTeam:main with commit 3937e67 Aug 5, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants