-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compaction): add file number limits to TWCS compaction #4481
Conversation
- Introduce `max_active_window_files` and `max_inactive_window_files` to `TwcsOptions`.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4481 +/- ##
==========================================
- Coverage 84.88% 84.65% -0.24%
==========================================
Files 1081 1081
Lines 192961 193336 +375
==========================================
- Hits 163798 163660 -138
- Misses 29163 29676 +513 |
…ions to mito engine config
…ment max file enforcement logging in TWCS compaction
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Please explain IN DETAIL what the changes are in this PR and why they are needed:
max_active_window_files
andmax_inactive_window_files
toTwcsOptions
.The SST's layout
Before
After
Checklist