Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): use DataFusion's optimizer #4489

Merged
merged 13 commits into from
Aug 29, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Aug 2, 2024

I hereby agree to the terms of the GreptimeDB CLA.

What's changed and what's your intention?

use and add a few Datafusion Analyzer and Optimizer to improve writing sql query in flow:
add three new analyzer in df_optimizer.rs file, which is also the major changes happen, other edits are either removal of obsolete functions or adding test for it

  • AvgExpandRule: rewrite avg to sum/count
  • TumbleExpandRule: rewrite tumble to tumble_start and tumble_end
  • CheckGroupByRule: check if all exprs in group by is also used in select list

also apply AnalyzerRule::TypeCoercion to cast type properly
optimizer from Datafusion is also appiled before encode to substrait, include:

  • OptimizeProjections: identifies and eliminates unused columns
  • CommonSubexprEliminate: avoid redundant computation of common sub-expressions
  • SimplifyExpressions: simplifies expressions in the logical plan
  • UnwrapCastInComparison: rewrites CAST(col) = lit to col = CAST(lit)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Aug 2, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Aug 2, 2024
@discord9 discord9 marked this pull request as ready for review August 2, 2024 08:37
@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners August 2, 2024 08:37
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 89.78723% with 96 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (0b102ef) to head (d9027cc).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4489      +/-   ##
==========================================
- Coverage   84.89%   84.68%   -0.22%     
==========================================
  Files        1101     1102       +1     
  Lines      197166   197601     +435     
==========================================
- Hits       167386   167329      -57     
- Misses      29780    30272     +492     

src/flow/src/plan.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/df_optimizer.rs Show resolved Hide resolved
src/flow/src/df_optimizer.rs Show resolved Hide resolved
src/flow/src/df_optimizer.rs Show resolved Hide resolved
refactor: mv `sql_to_flow_plan` elsewhere

feat(WIP): use df optimization

WIP analyzer rule

feat(WIP): avg expander

fix: transform avg expander

fix: avg expand

feat: names from substrait

fix: avg rewrite

test: update `test_avg`&`test_avg_group_by`

test: fix `test_sum`

test: fix some tests

chore: remove unused flow plan transform

feat: tumble expander

test: update tests
@fengjiachun
Copy link
Collaborator

@waynexia PTAL

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 This greatly simplifies the implementation.

src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/transform/expr.rs Outdated Show resolved Hide resolved
src/flow/src/df_optimizer.rs Show resolved Hide resolved
@discord9 discord9 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into GreptimeTeam:main with commit 9f9c1da Aug 29, 2024
32 checks passed
@discord9 discord9 deleted the flow_plan_fe branch August 29, 2024 03:07
CookiePieWw pushed a commit to CookiePieWw/greptimedb that referenced this pull request Sep 17, 2024
* feat: use datafusion optimization

refactor: mv `sql_to_flow_plan` elsewhere

feat(WIP): use df optimization

WIP analyzer rule

feat(WIP): avg expander

fix: transform avg expander

fix: avg expand

feat: names from substrait

fix: avg rewrite

test: update `test_avg`&`test_avg_group_by`

test: fix `test_sum`

test: fix some tests

chore: remove unused flow plan transform

feat: tumble expander

test: update tests

* chore: clippy

* fix: tumble lose `group expr`

* test: sqlness test update

* test: rm unused cast

* test: simplify sqlness

* refactor: per review

* chore: after rebase

* fix: remove a outdated test

* test: add comment

* fix: report error when not literal

* chore: update sqlness test after rebase

* refactor: per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants