Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(flow): use batch mode for flow #4599

Merged
merged 29 commits into from
Sep 11, 2024
Merged

perf(flow): use batch mode for flow #4599

merged 29 commits into from
Sep 11, 2024
+2,062 −781

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Aug 21, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

most of adds/deletes are just refactor and tests, core changes are only about 300 lines of code

  • refactor reduce.rs's reduce operator to be more efficient(only about 300 lines of code)
  • most other code changes are change from using row mode api to batch mode api or refactor
  • also change most debug log in flow to trace
  • add more flow usecase test

optimize flow to reduce cpu usage from 100% to 2.6%, and hardly any impact on tsbs write

before(100% cpu) flamegraph:
图片
after(1~2% cpu) flamegraph:
图片

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 21, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@discord9 discord9 changed the title perf(flow): use batch mode to reduce cpu usage by two order of magnitude perf(flow): use batch mode to reduce flow's cpu usage by two order of magnitude Aug 21, 2024
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Aug 21, 2024
@discord9 discord9 force-pushed the flow_use_batch_mode branch 2 times, most recently from 48063c0 to 9ef585c Compare August 23, 2024 11:23
@discord9 discord9 changed the title perf(flow): use batch mode to reduce flow's cpu usage by two order of magnitude perf(flow): use batch mode for flow Aug 26, 2024
@discord9 discord9 force-pushed the flow_use_batch_mode branch 2 times, most recently from 403c12f to b4678e2 Compare August 30, 2024 03:08
@discord9 discord9 marked this pull request as ready for review August 30, 2024 03:17
@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.37824% with 275 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (208afe4) to head (b055f10).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4599      +/-   ##
==========================================
- Coverage   84.81%   84.51%   -0.30%     
==========================================
  Files        1109     1114       +5     
  Lines      200016   200894     +878     
==========================================
+ Hits       169637   169787     +150     
- Misses      30379    31107     +728

zhongzc
zhongzc approved these changes Sep 3, 2024
View reviewed changes
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
zhongzc
zhongzc reviewed Sep 3, 2024
View reviewed changes
src/flow/src/repr.rs Outdated Show resolved Hide resolved
@discord9 discord9 requested a review from a team as a code owner September 3, 2024 12:00
@discord9
Copy link
Contributor Author

discord9 commented Sep 4, 2024

added some sqlness testcase for flow

killme2008
killme2008 reviewed Sep 9, 2024
View reviewed changes
src/flow/src/adapter/node_context.rs Outdated Show resolved Hide resolved
src/flow/src/compute/render/reduce.rs Outdated Show resolved Hide resolved
tests/cases/standalone/common/flow/flow_basic.sql Outdated Show resolved Hide resolved
@nicecui nicecui mentioned this pull request Sep 10, 2024
Merged
7 tasks
fengjiachun
fengjiachun approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/flow/src/compute/render/reduce.rs Outdated Show resolved Hide resolved
@discord9 discord9 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into GreptimeTeam:main with commit a3d567f Sep 11, 2024
32 checks passed
@discord9 discord9 deleted the flow_use_batch_mode branch September 11, 2024 03:47
CookiePieWw pushed a commit to CookiePieWw/greptimedb that referenced this pull request Sep 17, 2024
@discord9 @CookiePieWw
perf(flow): use batch mode for flow (GreptimeTeam#4599)
7d8d84c 
* generic bundle trait

* feat: impl get/let

* fix: drop batch

* test: tumble batch

* feat: use batch eval flow

* fix: div use arrow::div not mul

* perf: not append batch

* perf: use bool mask for reduce

* perf: tiny opt

* perf: refactor slow path

* feat: opt if then

* fix: WIP

* perf: if then

* chore: use trace instead

* fix: reduce missing non-first batch

* perf: flow if then using interleave

* docs: add TODO

* perf: remove unnecessary eq

* chore: remove unused import

* fix: run_available no longer loop forever

* feat: blocking on high input buf

* chore: increase threhold

* chore: after rebase

* chore: per review

* chore: per review

* fix: allow empty values in reduce&test

* tests: more flow doc example tests

* chore: per review

* chore: per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@zhongzc zhongzc zhongzc approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@discord9 @killme2008 @fengjiachun @waynexia @zhongzc