-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: skip checking the existence of the SST files #4602
refactor: skip checking the existence of the SST files #4602
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4602 +/- ##
==========================================
- Coverage 84.92% 84.92% -0.01%
==========================================
Files 1096 1096
Lines 196717 196699 -18
==========================================
- Hits 167063 167041 -22
- Misses 29654 29658 +4 |
What a dangerous API. |
refactor: skip checking the existence of the SST files when region is directly edited
…4602) refactor: skip checking the existence of the SST files when region is directly edited
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Mainly to lift out an expensive object store read when editing region directly.
By calling region edit from outside, greptimedb fully trust the caller. (Or put it in another way, the guarantee of the manifest correctness is not within the greptimedb itself.) An existence check of the SST files is less important than the latency of the interface.
Checklist