-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve toolchain resolution in ci #4614
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
I didn't see toolchain settings in actions for building linux artifacts, do we have them configured in builder images? Just saw this: https://github.com/GreptimeTeam/greptimedb/blob/main/docker/dev-builder/ubuntu/Dockerfile#L56 But it's ok because if rustup is installed it always follow the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4614 +/- ##
==========================================
- Coverage 84.94% 84.91% -0.03%
==========================================
Files 1096 1096
Lines 196772 196772
==========================================
- Hits 167148 167089 -59
- Misses 29624 29683 +59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* ci: improve toolchain resolution in ci * fix: yaml format
I hereby agree to the terms of the GreptimeDB CLA.
What's changed and what's your intention?
Update CI files. Write toolchain once, all downstream projects and CI should follow it.
Checklist