Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make init_global_logging() clean and add log_format #4657

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 31, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Add log_format, can be Text and Json;
  2. Refactor the init_global_logging;
  3. Make the file logging can be disabled;

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@zyy17 zyy17 requested a review from a team as a code owner August 31, 2024 18:05
Copy link
Contributor

coderabbitai bot commented Aug 31, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Aug 31, 2024
@zyy17 zyy17 changed the title refactor: refine the code logic of init_global_logging and add json output format refactor: make init_global_logging() clean and add log_format Aug 31, 2024
@zyy17 zyy17 force-pushed the refactor/output-json-logging branch 4 times, most recently from fa88a3c to 9347f89 Compare September 1, 2024 04:18
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 41.50943% with 62 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (8ca35a4) to head (98ea6ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4657      +/-   ##
==========================================
- Coverage   84.86%   84.56%   -0.30%     
==========================================
  Files        1105     1105              
  Lines      199151   199176      +25     
==========================================
- Hits       169000   168437     -563     
- Misses      30151    30739     +588     

@zyy17 zyy17 requested review from sunng87, MichaelScofield, evenyag and discord9 and removed request for a team September 1, 2024 04:57
@discord9 discord9 mentioned this pull request Sep 2, 2024
3 tasks
Copy link
Contributor

@discord9 discord9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 force-pushed the refactor/output-json-logging branch from a216c8f to 98ea6ce Compare September 3, 2024 14:34
@zyy17 zyy17 enabled auto-merge September 3, 2024 14:40
@zyy17 zyy17 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into GreptimeTeam:main with commit 8453df1 Sep 4, 2024
40 checks passed
@zyy17 zyy17 deleted the refactor/output-json-logging branch September 4, 2024 03:27
CookiePieWw pushed a commit to CookiePieWw/greptimedb that referenced this pull request Sep 17, 2024
…eptimeTeam#4657)

refactor: refine the code logic of init_global_logging and add json output format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants