-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more h3 scalar functions #4707
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4707 +/- ##
==========================================
- Coverage 84.82% 84.43% -0.39%
==========================================
Files 1109 1113 +4
Lines 199886 200909 +1023
==========================================
+ Hits 169549 169636 +87
- Misses 30337 31273 +936 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't look feeling good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch add more h3 functions and renamed previous
h3
toh3_latlng_to_cell_string
to avoid conflicts.h3_latlng_to_cell
h3_latlng_to_cell_string
h3_cell_base
h3_cell_parent
h3_cell_center_lat
h3_cell_center_lng
h3_cell_center_child
h3_cell_resolution
h3_cell_to_string
h3_string_to_cell
hs_is_neighbour
Checklist