Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use information_schema returns Unknown database #4774

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: use information_schema returns Unknown database #4774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5087ab
fix: use information_schema returns Unknown database 'information_sch…
J0HN50N133 Sep 26, 2024
a5c6aa0
test: make sure 'use information_schma' successful
J0HN50N133 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/frontend/src/instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ impl SqlQueryHandler for Instance {
.schema_exists(catalog, schema, None)
.await
.context(error::CatalogSnafu)
.map(|b| b && !self.catalog_manager.is_reserved_schema_name(schema))
}
}

Expand Down
4 changes: 4 additions & 0 deletions tests/cases/standalone/common/system/information_schema.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,10 @@ database my_db;

Affected Rows: 1

use information_schema;

Affected Rows: 0

use my_db;

Affected Rows: 0
Expand Down
2 changes: 2 additions & 0 deletions tests/cases/standalone/common/system/information_schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ select * from information_schema.columns order by table_schema, table_name, colu
create
database my_db;

use information_schema;

use my_db;

create table foo
Expand Down