Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose RegionMigrationManagerRef #4812

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Expose RegionMigrationManagerRef and tracker method of RegionMigrationManagerRef .

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (5f0a83b) to head (d7ff592).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4812      +/-   ##
==========================================
- Coverage   84.48%   84.17%   -0.32%     
==========================================
  Files        1120     1124       +4     
  Lines      204412   204759     +347     
==========================================
- Hits       172707   172346     -361     
- Misses      31705    32413     +708     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Oct 11, 2024
Merged via the queue into GreptimeTeam:main with commit 695ff1e Oct 11, 2024
33 checks passed
@WenyXu WenyXu deleted the chore/expose-struct branch October 11, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants