Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass raw_config_file arg to setup plugins functions #4821

Closed
wants to merge 2 commits into from

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

pass config_file arg to setup plugins functions

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner October 11, 2024 12:15
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (0f907ef) to head (352b592).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4821      +/-   ##
==========================================
- Coverage   84.43%   84.11%   -0.32%     
==========================================
  Files        1125     1127       +2     
  Lines      204873   205167     +294     
==========================================
- Hits       172979   172583     -396     
- Misses      31894    32584     +690     

@sunng87
Copy link
Member

sunng87 commented Oct 11, 2024

Is it essential when we already have the Options?

@WenyXu
Copy link
Member Author

WenyXu commented Oct 12, 2024

Is it essential when we already have the Options?

Yes, we may have some extend options

@WenyXu WenyXu enabled auto-merge October 12, 2024 03:02
@WenyXu WenyXu changed the title feat: pass config_file arg to setup plugins functions feat: pass raw_config_file arg to setup plugins functions Oct 12, 2024
@WenyXu WenyXu disabled auto-merge October 12, 2024 03:08
@WenyXu WenyXu marked this pull request as draft October 12, 2024 03:11
@WenyXu WenyXu closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants