-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add some s2 geo functions #4823
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4823 +/- ##
==========================================
- Coverage 84.37% 84.04% -0.33%
==========================================
Files 1127 1125 -2
Lines 205164 205140 -24
==========================================
- Hits 173104 172416 -688
- Misses 32060 32724 +664 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Lei, HUANG <6406592+v0y4g3r@users.noreply.github.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Please support. Thank you |
@adminpass Thank you for letting me know! I wonder if you have a use-case with geospatial functions in GreptimeDB or other time-series database? It will be helpful if you can describe the scenario so we can prioritize. |
For example:
|
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch introduces some new s2 geo encoding functions.
More information: http://s2geometry.io/
Checklist