Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache logical region's metadata #4827

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Cache logical region's metadata to accelerate query.

Given some metrics are likely never to be used, this cache is loaded lazily.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 87.07483% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (aaa9b32) to head (fd18afe).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4827      +/-   ##
==========================================
- Coverage   84.37%   84.07%   -0.30%     
==========================================
  Files        1127     1124       -3     
  Lines      205164   204944     -220     
==========================================
- Hits       173104   172312     -792     
- Misses      32060    32632     +572     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia added this pull request to the merge queue Oct 14, 2024
Merged via the queue into GreptimeTeam:main with commit 06e565d Oct 14, 2024
33 checks passed
@waynexia waynexia deleted the cache-logical-metadata branch October 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants