Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace info logs with debug logs in region server #4829

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Oct 14, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Tidy some logs in the region server

before after
image Downgraded to debug log
image Downgraded to debug log. With a new info log to display region counter. image
image Downgraded to debug log

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from a team as a code owner October 14, 2024 11:58
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 14, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (06e565d) to head (d03b2b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4829      +/-   ##
==========================================
- Coverage   84.33%   84.08%   -0.26%     
==========================================
  Files        1124     1124              
  Lines      204944   204946       +2     
==========================================
- Hits       172838   172321     -517     
- Misses      32106    32625     +519     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Oct 14, 2024
Merged via the queue into GreptimeTeam:main with commit b61a388 Oct 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants