Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sort within each PartitionRange #4847

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Oct 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • add a physical plan that sort within each PartitionRange boundary marked by empty RecordBatch
  • add fuzzy(ish) test for it

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 78.77238% with 83 lines in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (613e07a) to head (a16c1ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4847      +/-   ##
==========================================
- Coverage   84.30%   83.99%   -0.31%     
==========================================
  Files        1127     1129       +2     
  Lines      208553   208648      +95     
==========================================
- Hits       175814   175253     -561     
- Misses      32739    33395     +656     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant