fix: alter table add column id alloc mismatch

[discord9]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Fix a bug when altering a metric table and add a already existing columns in physical table caused column_id mismatch,
which would cause datafusion to panic in certain condition, related sqlness tests are also added

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Bug Explain

The bug is:

1. Two metrics tables have been created that share a single physical table.
2. Table A has added a column named "at", with a column ID of 1.
3. After some time, Table B attempts to add the "at" column:
   • It uses the column_semantic_type function to check and finds that it does not have this column, so it adds it to the columns_to_add list.
   • It sends an alter request to Mito, specifying the column definition as ("at" String null Tag 2), knowing that the maximum column ID is 1.
   • Mito receives the request and discovers that the "at" column already exists (as seen in store_api::metadata::RegionMetadataBuilder::add_columns). It ignores the request, does not add the column to the physical table, and does not return an error.
   • The metrics engine, not receiving an error, assumes the column addition was successful and adds ("at" String null Tag 2) to the logical table.
4. At this point, the column ID for "at" is seen as 1 in both Table A and the physical table, while Table B sees it as 2.

Solution is to check physical region for actual column_id(and other metadata) to update to logical region

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.81%. Comparing base (0e0c4fa) to head (bf558d0).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4972      +/-   ##
==========================================
- Coverage   84.07%   83.81%   -0.27%     
==========================================
  Files        1143     1143              
  Lines      211918   212639     +721     
==========================================
+ Hits       178172   178213      +41     
- Misses      33746    34426     +680     

[waynexia]

💯

[fengjiachun]

LGTM