Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mito): change the table path to schema/table_id #728

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented Dec 8, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

using table id as the table data path to support RENAME TABLE, the relevant logic has already been validated in the unit test test_open_table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

more details in #660

@e1ijah1 e1ijah1 mentioned this pull request Dec 8, 2022
5 tasks
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #728 (7e6cf83) into develop (4fdf268) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #728      +/-   ##
===========================================
- Coverage    86.40%   86.29%   -0.12%     
===========================================
  Files          449      449              
  Lines        58505    58499       -6     
===========================================
- Hits         50551    50480      -71     
- Misses        7954     8019      +65     
Flag Coverage Δ
rust 86.29% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mito/src/engine.rs 98.85% <100.00%> (-0.01%) ⬇️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/servers/src/error.rs 33.33% <0.00%> (-20.52%) ⬇️
tests-integration/src/test_util.rs 88.15% <0.00%> (-11.38%) ⬇️
src/datanode/src/instance.rs 31.46% <0.00%> (-11.24%) ⬇️
src/frontend/src/table/scan.rs 75.80% <0.00%> (-4.84%) ⬇️
src/servers/src/grpc.rs 91.17% <0.00%> (-2.95%) ⬇️
src/meta-srv/src/service/heartbeat.rs 86.31% <0.00%> (-1.06%) ⬇️
src/servers/src/mysql/writer.rs 70.76% <0.00%> (-0.77%) ⬇️
src/common/substrait/src/df_expr.rs 30.91% <0.00%> (-0.68%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit c1b8981 into GreptimeTeam:develop Dec 9, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eam#728)

refactor: change the table path to `schema/table_id`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants