Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rename table #802

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented Dec 29, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

implement renaming table in mito table engine

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#723

@e1ijah1 e1ijah1 marked this pull request as ready for review December 31, 2022 17:14
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts that you might need to resolve

src/mito/src/table.rs Outdated Show resolved Hide resolved
src/mito/src/table.rs Outdated Show resolved Hide resolved
src/mito/src/table.rs Outdated Show resolved Hide resolved
src/datanode/src/sql/alter.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #802 (5b75e62) into develop (5fcad7a) will increase coverage by 0.03%.
The diff coverage is 86.73%.

❗ Current head 5b75e62 differs from pull request most recent head f188958. Consider uploading reports for the commit f188958 to get more accurate results

@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
+ Coverage    85.23%   85.26%   +0.03%     
===========================================
  Files          417      416       -1     
  Lines        54918    54382     -536     
===========================================
- Hits         46808    46371     -437     
+ Misses        8110     8011      -99     
Flag Coverage Δ
rust 85.26% <86.73%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/grpc-expr/src/alter.rs 93.84% <0.00%> (-4.55%) ⬇️
src/sql/src/statements/alter.rs 30.00% <0.00%> (+1.42%) ⬆️
src/table/src/metadata.rs 96.08% <0.00%> (-0.19%) ⬇️
src/table/src/requests.rs 62.50% <ø> (ø)
src/datanode/src/sql/alter.rs 88.88% <92.85%> (-0.25%) ⬇️
src/mito/src/engine.rs 99.00% <100.00%> (+0.13%) ⬆️
src/mito/src/table.rs 92.60% <100.00%> (-0.28%) ⬇️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/query/src/error.rs 24.00% <0.00%> (-31.00%) ⬇️
tests-integration/src/test_util.rs 87.74% <0.00%> (-11.77%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@e1ijah1 e1ijah1 requested a review from evenyag January 3, 2023 06:13
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might need to resolve the conflicts again 😢

@e1ijah1
Copy link
Contributor Author

e1ijah1 commented Jan 3, 2023

LGTM. You might need to resolve the conflicts again 😢

It's all fixed now.

@waynexia waynexia merged commit a6eb213 into GreptimeTeam:develop Jan 3, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: support renaming tables in the mito table engine

* chore: add test for table engine

* chore: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants