-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run sqlness test in distributed mode #916
test: run sqlness test in distributed mode #916
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
- Coverage 86.25% 86.03% -0.23%
===========================================
Files 430 434 +4
Lines 57928 58342 +414
===========================================
+ Hits 49968 50192 +224
- Misses 7960 8150 +190
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, thx @e1ijah1 ! However, the sqlness test action is failed, can you take a look?
It looks like the datanode process failed to start. I tested it in both Linux and Mac environments but couldn't reproduce the issue. Could you please take a look at |
@e1ijah1 Seems that log cannot be downloaded? Can you |
I'll upload the logs as CI artifacts, give me a minute |
My bad. Sqlness Job doesn't start etcd, causing the issue. The problem has been resolved. |
There are some conflicts with #920
👍 |
fixed, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, appreciate it @e1ijah1 ❤️
* test: run sqlness test in distributed mode * chore: fix ci test * chore: improve the ci yaml * chore: improve the code * chore: fix conflicts
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)