fix: handle Expr::Binary properly in walk_expr

[scintillavoy]

When handling Expr::Binary in walk_expr, the return values from lhs and rhs are ORed (||) but it should be &&.

For example, let the expression be foo{l1="v1"} + bar{l2="v2"}. walk_expr will recurse into lhs (foo) first and if the return value is Ok(true), it should recurse into rhs (bar) but it would not.

Additionally, there was a small inconsistency in the example (newlines between the output), so I fixed it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (6e46e66) to head (36fc304).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          14       14           
  Lines        6272     6296   +24     
=======================================
+ Hits         6209     6233   +24     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[waynexia]

Looking great! Thanks for this fixing.

This PR is good enough for merging. It would be better if you are willing to add a unit test to reflect this change!

[evenyag]

Thanks! Could you please fix the clippy warning?

[scintillavoy]

@waynexia

Looking great! Thanks for this fixing.

This PR is good enough for merging. It would be better if you are willing to add a unit test to reflect this change!

I added some tests, but I'm new to Rust so please check if I organized the code correctly. 😅

[scintillavoy]

@evenyag

Thanks! Could you please fix the clippy warning?

I checked it, but I have no idea how to fix it. The message says there are possible "refactorings" in the file promql.y.rs and it seems it is not introduced by the changes from this PR.

[waynexia]

Thank you @scintillavoy ❤️