Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement Display for EvalStmt #91

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

zyy17
Copy link
Contributor

@zyy17 zyy17 commented Oct 8, 2024

What's changed

Implement fmt::Display for EvalStmt for better logging.

Signed-off-by: zyy17 <zyylsxm@gmail.com>
@zyy17 zyy17 requested review from waynexia and evenyag October 8, 2024 07:57
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (a561f2c) to head (9779d91).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   98.99%   98.98%   -0.02%     
==========================================
  Files          14       14              
  Lines        6296     6320      +24     
==========================================
+ Hits         6233     6256      +23     
- Misses         63       64       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyy17 zyy17 requested a review from evenyag October 9, 2024 03:19
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 7d33ca9 into GreptimeTeam:main Oct 9, 2024
5 checks passed
@zyy17 zyy17 deleted the refactor/eval-stmt-display branch October 9, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants