Skip to content

Commit

Permalink
workflow: document issue/pr workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
yyx990803 committed Mar 19, 2021
1 parent 2eb7682 commit 1848199
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,16 @@ Some common test helpers, e.g. `testDir`, `isBuild` or `editFile` are available

> The following section is mostly for maintainers who have commit access, but it's helpful to go through if you intend to make non-trivial contributions to the codebase.
### Issue Triaging Workflow

![issue-workflow](./issue-workflow.png)

### Pull Request Review Workflow

![issue-workflow](./pr-workflow.png)

## Notes on Dependencies

Vite aims to be lightweight, and this includes being aware of the number of npm dependencies and their size.

We use rollup to pre-bundle most dependencies before publishing! Therefore most dependencies, even used in src code, should be added under `devDependencies` by default. This also creates a number of constraints that we need to be aware of in the codebase:
Expand Down
Binary file added .github/issue-workflow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .github/pr-workflow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 1848199

Please sign in to comment.