fix warnings

GuOrg · Apr 5, 2023 · 3c10ee3 · 3c10ee3
1 parent 79011ad
commit 3c10ee3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/Gu.Roslyn.Asserts.Tests/.editorconfig b/Gu.Roslyn.Asserts.Tests/.editorconfig
@@ -44,3 +44,4 @@ dotnet_diagnostic.VSTHRD200.severity = none
 # VSTHRD103: Call async methods when in an async method
 dotnet_diagnostic.VSTHRD103.severity = none
 
+dotnet_diagnostic.REFL039.severity = none
diff --git a/Gu.Roslyn.Asserts/Internals/DefaultEnabledAnalyzer.cs b/Gu.Roslyn.Asserts/Internals/DefaultEnabledAnalyzer.cs
@@ -15,25 +15,24 @@ internal sealed class DefaultEnabledAnalyzer : DiagnosticAnalyzer
 {
     private readonly DiagnosticAnalyzer inner;
 
-    public DefaultEnabledAnalyzer(DiagnosticAnalyzer inner)
+    internal DefaultEnabledAnalyzer(DiagnosticAnalyzer inner)
     {
         this.inner = inner;
         this.SupportedDiagnostics = EnabledDiagnostics(inner.SupportedDiagnostics);
 
         static ImmutableArray<DiagnosticDescriptor> EnabledDiagnostics(ImmutableArray<DiagnosticDescriptor> source)
         {
             var builder = ImmutableArray.CreateBuilder<DiagnosticDescriptor>(source.Length);
-            for (var i = 0; i < source.Length; i++)
+            foreach (var diagnostic in source)
             {
-                var diagnostic = source[i];
                 builder.Add(
                     new DiagnosticDescriptor(
                         diagnostic.Id,
                         diagnostic.Title,
                         diagnostic.MessageFormat,
                         diagnostic.Category,
                         diagnostic.DefaultSeverity,
-                        true,
+                        isEnabledByDefault: true,
                         diagnostic.Description,
                         diagnostic.HelpLinkUri,
                         diagnostic.CustomTags?.ToArray() ?? Array.Empty<string>()));
@@ -45,5 +44,7 @@ static ImmutableArray<DiagnosticDescriptor> EnabledDiagnostics(ImmutableArray<Di
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
 
+#pragma warning disable RS1025, RS1026
     public override void Initialize(AnalysisContext context) => this.inner.Initialize(context);
+#pragma warning restore RS1025, RS1026
 }
diff --git a/Gu.Roslyn.Asserts/Internals/StringLoader.cs b/Gu.Roslyn.Asserts/Internals/StringLoader.cs
@@ -1,4 +1,4 @@
-namespace Gu.Roslyn.Asserts.Internals;
+namespace Gu.Roslyn.Asserts.Internals;
 
 using System.Text;
 using System.Threading;
@@ -32,7 +32,8 @@ internal StringLoader(string document)
     internal string Code { get; }
 
     /// <inheritdoc />
-    public override Task<TextAndVersion> LoadTextAndVersionAsync(Workspace workspace, DocumentId documentId, CancellationToken cancellationToken) => this.textAndVersion;
+    [System.Obsolete]
+    public override Task<TextAndVersion> LoadTextAndVersionAsync(Workspace? workspace, DocumentId? documentId, CancellationToken cancellationToken) => this.textAndVersion;
 
     /// <summary>
     /// Create a <see cref="StringLoader"/> for the document.