Skip to content

Commit

Permalink
Fix cli options (sigp#4772)
Browse files Browse the repository at this point in the history
## Issue Addressed

Fixes breaking change introduced on sigp#4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
  • Loading branch information
jxs committed Sep 22, 2023
1 parent fbb6997 commit 0f05499
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion beacon_node/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1273,5 +1273,5 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
.default_value("64")
.takes_value(true)
)
.group(ArgGroup::with_name("enable_http").args(&["http", "gui", "staking"]))
.group(ArgGroup::with_name("enable_http").args(&["http", "gui", "staking"]).multiple(true))
}
12 changes: 12 additions & 0 deletions lighthouse/tests/beacon_node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2337,6 +2337,18 @@ fn gui_flag() {
});
}

#[test]
fn multiple_http_enabled_flags() {
CommandLineTest::new()
.flag("gui", None)
.flag("http", None)
.flag("staking", None)
.run_with_zero_port()
.with_config(|config| {
assert!(config.http_api.enabled);
});
}

#[test]
fn optimistic_finalized_sync_default() {
CommandLineTest::new()
Expand Down

0 comments on commit 0f05499

Please sign in to comment.