Feature/crop #56
Merged
Feature/crop #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. split the call to hexagon() from line 53 in sticker() into three calls. The first, to geom_hexagon(), puts the background and is before (under) the plot. The second, to geom_hexagon(), puts the line around the edge and is after (on top of) the plot. The third, to theme_sticker, puts the theme. So function hexagon() is no longer needed, so I commented it out. 2. added the ... argument to sticker() and passed it to geom_pkgname(). 3. addedargument to sticker() called `white_around_sticker`, which defaults to FALSE. But if set to TRUE, it puts white triangles in the corners as the last step in plotting, so as to cover up any plot that went outside the hexagon.
This was referenced Mar 13, 2019
|
you can add your name in the author list, https://github.com/GuangchuangYu/hexSticker/blob/master/DESCRIPTION#L4-L8, as a contributor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message on 88a03e8