forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#112708 - flip1995:clippy-freezing-pc-with-i…
…ce, r=cjgillot Revert "Don't hold the active queries lock while calling `make_query`" This reverts commit fd3d2d4. This has the side effect, that when Clippy should ICE (during an EarlyPass?) it will fill up the RAM with 2 GB/s and then freezes the PC. I don't know the correct solution, but this is blocking the Clippy sync and might give some people really bad experiences, so this should be reverted ASAP. Reverts rust-lang#112333 r? `@cjgillot` cc `@Zoxc` I only commented this on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60try_print_query_stack.60.20has.20.60ImplicitCtx.60.20during.20.60EarlyPass.60/near/363926180). I should've left a comment on the PR as well. My bad.
- Loading branch information
Showing
3 changed files
with
31 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// compile-flags: -Ztreat-err-as-bug | ||
// dont-check-failure-status | ||
// error-pattern: aborting due to `-Z treat-err-as-bug=1` | ||
// normalize-stderr-test "note: .*\n\n" -> "" | ||
// normalize-stderr-test "thread 'rustc' panicked.*\n" -> "" | ||
// rustc-env:RUST_BACKTRACE=0 | ||
|
||
fn main() { | ||
#[deny(while_true)] | ||
while true {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
error: denote infinite loops with `loop { ... }` | ||
--> $DIR/panic-causes-oom-112708.rs:10:5 | ||
| | ||
LL | while true {} | ||
| ^^^^^^^^^^ help: use `loop` | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/panic-causes-oom-112708.rs:9:12 | ||
| | ||
LL | #[deny(while_true)] | ||
| ^^^^^^^^^^ | ||
|
||
error: the compiler unexpectedly panicked. this is a bug. | ||
|
||
query stack during panic: | ||
thread panicked while processing panic. aborting. |