Merge pull request #926 from angular/main

Create a new pull request by comparing changes across two branches
GulajavaMinistudio · Sep 18, 2024 · ac4ccf6 · ac4ccf6
2 parents 033280a + ed2aecf
commit ac4ccf6
Show file tree

Hide file tree

Showing 111 changed files with 3,938 additions and 1,800 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -33,8 +33,24 @@
     "project": "tsconfig.json",
     "sourceType": "module"
   },
-  "plugins": ["eslint-plugin-import", "header", "@typescript-eslint"],
+  "plugins": ["@stylistic", "@typescript-eslint", "eslint-plugin-import", "header"],
   "rules": {
+    "@stylistic/lines-around-comment": [
+      "error",
+      {
+        "allowArrayStart": true,
+        "allowBlockStart": true,
+        "allowClassStart": true,
+        "allowEnumStart": true,
+        "allowInterfaceStart": true,
+        "allowModuleStart": true,
+        "allowObjectStart": true,
+        "allowTypeStart": true,
+        "beforeBlockComment": true,
+        "ignorePattern": "@license"
+      }
+    ],
+    "@stylistic/spaced-comment": ["error", "always"],
     "@typescript-eslint/consistent-type-assertions": "error",
     "@typescript-eslint/no-explicit-any": "error",
     "@typescript-eslint/no-non-null-assertion": "error",

diff --git a/.github/workflows/assistant-to-the-branch-manager.yml b/.github/workflows/assistant-to-the-branch-manager.yml
@@ -16,6 +16,6 @@ jobs:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           persist-credentials: false
-      - uses: angular/dev-infra/github-actions/branch-manager@18033eeb81c00d6867f980105fa503721ada7aa3
+      - uses: angular/dev-infra/github-actions/branch-manager@12e38ba595aa3bbe4230e9568517c7309fca93bc
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Generate JSON schema types
@@ -42,11 +42,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Build release targets
@@ -56,11 +56,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Run module and package tests
@@ -90,13 +90,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -111,13 +111,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -132,13 +132,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -149,13 +149,13 @@ jobs:
       SAUCE_TUNNEL_IDENTIFIER: angular-cli-${{ github.workflow }}-${{ github.run_number }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run E2E Browser tests
         env:
           SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}
@@ -182,11 +182,11 @@ jobs:
       CIRCLE_BRANCH: ${{ github.ref_name }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - run: yarn admin snapshots --verbose
         env:
           SNAPSHOT_BUILDS_GITHUB_TOKEN: ${{ secrets.SNAPSHOT_BUILDS_GITHUB_TOKEN }}
diff --git a/.github/workflows/dev-infra.yml b/.github/workflows/dev-infra.yml
@@ -13,13 +13,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - uses: angular/dev-infra/github-actions/commit-message-based-labels@18033eeb81c00d6867f980105fa503721ada7aa3
+      - uses: angular/dev-infra/github-actions/commit-message-based-labels@12e38ba595aa3bbe4230e9568517c7309fca93bc
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
   post_approval_changes:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - uses: angular/dev-infra/github-actions/post-approval-changes@18033eeb81c00d6867f980105fa503721ada7aa3
+      - uses: angular/dev-infra/github-actions/post-approval-changes@12e38ba595aa3bbe4230e9568517c7309fca93bc
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/feature-requests.yml b/.github/workflows/feature-requests.yml
@@ -16,6 +16,6 @@ jobs:
     if: github.repository == 'angular/angular-cli'
     runs-on: ubuntu-latest
     steps:
-      - uses: angular/dev-infra/github-actions/feature-request@18033eeb81c00d6867f980105fa503721ada7aa3
+      - uses: angular/dev-infra/github-actions/feature-request@12e38ba595aa3bbe4230e9568517c7309fca93bc
         with:
           angular-robot-key: ${{ secrets.ANGULAR_ROBOT_PRIVATE_KEY }}
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -34,7 +34,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup ESLint Caching
         uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
         with:
@@ -54,7 +54,7 @@ jobs:
       - name: Run Validation
         run: yarn admin validate
       - name: Check Package Licenses
-        uses: angular/dev-infra/github-actions/linting/licenses@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/linting/licenses@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Check tooling setup
         run: yarn check-tooling-setup
       - name: Check commit message
@@ -70,11 +70,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Build release targets
@@ -90,11 +90,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Run module and package tests
@@ -111,13 +111,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -132,13 +132,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
 
@@ -155,12 +155,12 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Initialize environment
-        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Install node modules
         run: yarn install --immutable
       - name: Setup Bazel
-        uses: angular/dev-infra/github-actions/bazel/setup@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/setup@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Setup Bazel RBE
-        uses: angular/dev-infra/github-actions/bazel/configure-remote@18033eeb81c00d6867f980105fa503721ada7aa3
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@12e38ba595aa3bbe4230e9568517c7309fca93bc
       - name: Run CLI E2E tests
         run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
@@ -46,6 +46,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: 'Upload to code-scanning'
-        uses: github/codeql-action/upload-sarif@4dd16135b69a43b6c8efb853346f8437d92d3c93 # v3.26.6
+        uses: github/codeql-action/upload-sarif@8214744c546c1e5c8f03dde8fab3a7353211988d # v3.26.7
         with:
           sarif_file: results.sarif