Adding <select multiple> styles #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using Gumby in a new project and while updating HTML elements such as radio buttons, check boxes, and select elements I found that multi selects were not part of the Gumby UI demo. I checked the CSS files and found no styling other than '.picker select'. Prefacing the <select> elements with the 'picker' class triggers Gumby's design updates to the select (making multi-selects appear like drop down selects) so instead I think a new class of 'multi-picker' could help and be used as the wrapper for multi-selects instead of 'picker'.
Select "Picker" Example:
<div class="picker">
<select>
<option value="#" disabled="">Favorite Dalek phrase...</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
</select>
</div>
Select "Multi-Picker" Example:
<div class="multi-picker">
<select multiple="multiple">
<option value="#" disabled="">Favorite Dalek phrase...</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
</select>
</div>
The proposed styles attempt to use many of the same styles already used in Gumby's UI for <select> differing only where needed such as background-image/color, padding, etc.
danhere
added a commit
that referenced
this pull request
Feb 15, 2015
Adding <select multiple> styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using Gumby in a new project and while updating HTML elements such as radio buttons, check boxes, and select elements I found that multi selects were not part of the Gumby UI demo. I checked the CSS files and found no styling other than '.picker select'. Prefacing the <select> elements with the 'picker' class triggers Gumby's design updates to the select (making multi-selects appear like drop down selects) so instead I think a new class of 'multi-picker' could help and be used as the wrapper for multi-selects instead of 'picker'.
Select "Picker" Example:
<div class="picker">
<select>
<option value="#" disabled="">Favorite Dalek phrase...</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
</select>
</div>
Select "Multi-Picker" Example:
<div class="multi-picker">
<select multiple="multiple">
<option value="#" disabled="">Favorite Dalek phrase...</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
<option>EXTERMINATE</option>
</select>
</div>
The proposed styles attempt to use many of the same styles already used in Gumby's UI for <select> differing only where needed such as background-image/color, padding, etc.