Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean impl service #249

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Clean impl service #249

merged 4 commits into from
Dec 8, 2024

Conversation

H1rono
Copy link
Owner

@H1rono H1rono commented Dec 8, 2024

close #245

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (e68c620) to head (f3ba4aa).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/handler/future.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files          17       17           
  Lines        1753     1753           
=======================================
  Hits         1212     1212           
  Misses        541      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono merged commit c9f3542 into main Dec 8, 2024
5 of 7 checks passed
@H1rono H1rono deleted the clean-impl-service branch December 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl Serviceの方針をスッキリさせる
1 participant