Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es_deactivate error in 0.7.7 #43

Closed
codekiln opened this issue Oct 2, 2018 · 0 comments · Fixed by #49
Closed

es_deactivate error in 0.7.7 #43

codekiln opened this issue Oct 2, 2018 · 0 comments · Fixed by #49
Assignees

Comments

@codekiln
Copy link
Contributor

codekiln commented Oct 2, 2018

Currently, if you run ./manage.py es_list and you see all activated IndexVersions, and then you run ./manage.py es_deactivate myindex where myindex is the name of a formerly activated index, you will get a stack trace on all management comands after that. For example, subsequently running ./manage.py es_list gives:

[2018-10-02 14:25:17.722210]: While completing create_index, encountered exception: 
 - message: Empty value passed for a required argument 'index'. 
 - exception doc: Inappropriate argument value (of correct type). 
 - exception stack: Traceback (most recent call last):
  File "/home/ubuntu/hbx/python/src/django-elastic-migrations/django_elastic_migrations/models.py", line 326, in start_action
    result = self.perform_action(dem_index, *args, **kwargs)
  File "/home/ubuntu/hbx/python/src/django-elastic-migrations/django_elastic_migrations/models.py", line 702, in perform_action
    created = dem_index.create_if_not_in_es()
  File "/home/ubuntu/hbx/python/src/django-elastic-migrations/django_elastic_migrations/indexes.py", line 832, in create_if_not_in_es
    raise ex
  File "/home/ubuntu/hbx/python/src/django-elastic-migrations/django_elastic_migrations/indexes.py", line 826, in create_if_not_in_es
    self.connection.indices.create(index=index, body=body, **kwargs)
  File "/home/ubuntu/hbx/python/lib/python3.5/site-packages/elasticsearch/client/utils.py", line 76, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/home/ubuntu/hbx/python/lib/python3.5/site-packages/elasticsearch/client/indices.py", line 86, in create
    raise ValueError("Empty value passed for a required argument 'index'.")
ValueError: Empty value passed for a required argument 'index'.

This task is to either remove es_deactivate (since it's not really a needed feature) or to fix the bug and add tests for it.

@codekiln codekiln self-assigned this Oct 2, 2018
codekiln added a commit that referenced this issue Nov 12, 2018
es_deactivate error in 0.7.7 #43
codekiln added a commit that referenced this issue Nov 12, 2018
es_deactivate error in 0.7.7 #43
codekiln added a commit that referenced this issue Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant