Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage for es_list #50

Closed
codekiln opened this issue Nov 12, 2018 · 0 comments
Closed

add test coverage for es_list #50

codekiln opened this issue Nov 12, 2018 · 0 comments
Assignees
@codekiln
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codekiln
Copy link
Contributor

es_list is one area that is still missing from coverage:
es_list missing coverage

this task is to add coverage to es_list.
@codekiln codekiln assigned codekiln and unassigned codekiln Nov 12, 2018
@codekiln codekiln added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 13, 2018
@codekiln codekiln self-assigned this Nov 17, 2018
codekiln added a commit that referenced this issue Nov 17, 2018
@codekiln
#50 add test coverage for es_list
a231918
@codekiln codekiln mentioned this issue Nov 17, 2018
Merged
codekiln added a commit that referenced this issue Nov 17, 2018
@codekiln
add more accurate way to assert es_list table contents
50f3ffe 
* we can't hardcode the index numbers, since the primary key will
  change according to how many tests have created indexes
* created helper methods for generating the expected tables from
  es_list

#50 add test coverage for es_list
codekiln added a commit that referenced this issue Nov 18, 2018
@codekiln
fill out more significant tests for es_list
bc7316d 
* add helper methods for asserting contents of table
* we can't hardcode the index numbers, since the primary key will
  change according to how many tests have created indexes
* created helper methods for generating the expected tables from
  es_list
* fix problem with docker image failing to work because of xpack, which
  isn't being used anyway
* separate out `delete_dem_index_from_es` from `destroy_dem_index` for
  use in testing
* create `list_es_doc_counts` which is more efficient than looking them
  up for each index anyway
* exclude indexes that start with a period

#50 add test coverage for es_list
#58 ignore indexes with a dot in name in es_list --es-only and es_dangerous_reset
codekiln added a commit that referenced this issue Nov 18, 2018
@codekiln
sort rows in es_list so as to avoid ordering ambiguity in tests
f2d3838 
* move `EsListRow` into `es_list` and use it there
* minor cleanup in indexes.py

#50 add test coverage for es_list
#58 ignore indexes with a dot in name in es_list --es-only and es_dangerous_reset
codekiln added a commit that referenced this issue Nov 18, 2018
@codekiln
bump 0.8.0 --> 0.8.1
4e9f34a 
#50 add test coverage for es_list
#58 ignore indexes with a dot in name in es_list --es-only and es_dangerous_reset
codekiln added a commit that referenced this issue Nov 19, 2018
@codekiln
use .hidden-index in simpler way in es_list & es_dangerous_reset tests
936c1b5 
#50 add test coverage for es_list
#58 ignore indexes with a dot in name in es_list --es-only and es_dangerous_reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codekiln codekiln

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codekiln