#6 support django 2 #48
Conversation
* fixed a `queue` import error with multiprocessing_utils.py
* Added Django 2.0 and 2.1 to test matrix
* Added models.CASCADE to every foreign key except one:
Index.active_version. Generated migration for that one to set it to
null upon delete instead.
* use utf-8 encoding for generating hash, but save bytestring to db
instead, so as to avoid saving `b'{json here}'` into the `json` field
of IndexVersion in Django 2; see
https://docs.djangoproject.com/en/2.1/releases/2.0/#removed-support-for-bytestrings-in-some-places
for more info.
#6 support django 2
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 18 18
Lines 847 847
Branches 132 132
=======================================
Hits 601 601
Misses 192 192
Partials 54 54
Continue to review full report at Codecov.
|
| md5_hash = hashlib.md5() | ||
| md5_hash.update(json_str) | ||
| md5_hash.update(json_str.encode('utf-8')) |
There was a problem hiding this comment.
In Django 2.0 release notes, they mention they "Removed support for bytestrings in some places". One of those places is saving text to a standard TextField, where starting in 2.0 if you save a bytestring it looks like b'my bytestring' in the database; you need to supply it a normal str to get the expected behavior.
At the same time, md5_hash requires a bytestring, so this moves the .encode('utf-8') to just that function, but returns the str that comes out of json.dumps.
| migrations.AlterField( | ||
| model_name='index', | ||
| name='active_version', | ||
| field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='+', to='django_elastic_migrations.IndexVersion'), |
There was a problem hiding this comment.
Django 2.0 requires explicit on_delete handlers for foreign keys. I've used the default, models.CASCADE, in all places except one: Index.active_version, which should just be set to null if the IndexVersion is deleted. This migration captures that change.
|
closes #44 add django 1.10 and 1.11 to test matrix |
Dependency: PR #46 remove support for python 2. That should be merged first, removing commits from this PR.
Adds support to Django 2.0 for #6