Convert vds swmr test script to powershell #1245

byrnHDF · 2021-12-01T14:52:32Z

No description provided.

* Use stdout instead of file for configure check * Make change requested by #1157 * Change fortran to use stderr for configure * Correct typo * remove obsolete file check * Fortran statement fix

derobins · 2021-12-01T16:32:31Z

test/testswmr.pwsh.in

@@ -0,0 +1,537 @@
+#! /bin/bash


We're not using bash :)

derobins · 2021-12-01T16:33:09Z

release_docs/RELEASE.txt

@@ -47,6 +47,16 @@ New Features

    Configuration:
    -------------
+    - CMake will now run the power shell script tests in test/ by default


PowerShell is the correct spelling

test/ShellTests.cmake

derobins · 2021-12-01T16:41:44Z

test/ShellTests.cmake

+#    set_tests_properties (H5SHELL-test_usecases PROPERTIES
+#            ENVIRONMENT "LD_LIBRARY_PATH=$ENV{LD_LIBRARY_PATH}:${CMAKE_RUNTIME_OUTPUT_DIRECTORY}"
+#            WORKING_DIRECTORY ${HDF5_TEST_BINARY_DIR}/H5TEST
+#    )


Why is this commented out?

Will clean.

test/ShellTests.cmake

byrnHDF · 2021-12-01T20:14:20Z

test/testswmr.pwsh.in

+    )
+
+    PROCESS {
+        $message = Join-Path -Path $testdir -ChildPath $Message


I think $testdir needs to passed in as well - $testdir gets changed later to the test folder.

lrknox · 2021-12-08T14:44:26Z

test/testvdsswmr.pwsh.in

@@ -0,0 +1,211 @@
+# Copyright by The HDF Group.
+# Copyright by the Board of Trustees of the University of Illinois.


Assuming this is a new file, the Board of Trustees line should be removed.

lrknox · 2021-12-08T14:44:38Z

test/testswmr.pwsh.in

@@ -0,0 +1,537 @@
+# Copyright by The HDF Group.
+# Copyright by the Board of Trustees of the University of Illinois.


Assuming this is a new file, the Board of Trustees line should be removed.

…evelop-pwsh

byrnHDF and others added 20 commits November 18, 2021 15:17

Convert SWMR shell scripts to Windows powershell.

9ca362c

Use $LastExitCode instead of $? in script

17107b7

Prevent execution in a different window

5a48427

Github #969 Use stdout instead of file for configure check (#1089)

87940e8

* Use stdout instead of file for configure check * Make change requested by #1157 * Change fortran to use stderr for configure * Correct typo * remove obsolete file check * Fortran statement fix

Don't allow H5Pset(get)_all_coll_metadata_ops for DXPLs (#1201)

2d1f708

Fixes const warnings in H5ES package (#1211)

2852cf8

Quiets a 'set but not used' warning in h5diff_array.c (#1210)

114df8f

Convert vds swmr test script to powershell

4946dd3

Enable vdsswmr powershell test

45cc737

Add configure vdsswmr statement

15a1f96

Correct powershell script vars

e0ffedc

Convert SWMR shell scripts to Windows powershell.

4d9aaa8

Use $LastExitCode instead of $? in script

12d921a

Prevent execution in a different window

0f8c84d

Github #969 Use stdout instead of file for configure check (#1089)

518c561

* Use stdout instead of file for configure check * Make change requested by #1157 * Change fortran to use stderr for configure * Correct typo * remove obsolete file check * Fortran statement fix

Convert vds swmr test script to powershell

feed5c7

Enable vdsswmr powershell test

59df326

Add configure vdsswmr statement

9a04e83

Correct powershell script vars

b86e1f2

Merge branch 'develop-pwsh'

5df81f9

byrnHDF self-assigned this Dec 1, 2021

byrnHDF requested review from bmribler, derobins, fortnern, jhendersonHDF, jrmainzer, lrknox, qkoziol, soumagne and vchoi-hdfgroup as code owners December 1, 2021 14:52

derobins reviewed Dec 1, 2021

View reviewed changes

test/ShellTests.cmake Show resolved Hide resolved

derobins reviewed Dec 1, 2021

View reviewed changes

Cleanup review issues

2b7a0f7

derobins reviewed Dec 1, 2021

View reviewed changes

test/ShellTests.cmake Show resolved Hide resolved

derobins approved these changes Dec 1, 2021

View reviewed changes

Fix variable assignment

921ef71

byrnHDF commented Dec 1, 2021

View reviewed changes

byrnHDF added 2 commits December 1, 2021 14:33

Change the wait function to pass in the path

6211689

Disable actual test execution until programs fixed

49a0ac8

lrknox reviewed Dec 8, 2021

View reviewed changes

byrnHDF added 3 commits December 8, 2021 10:31

Adjust copyright text

ec9a152

Merge branch 'develop' of https://github.com/HDFGroup/hdf5.git into d…

bec67b4

…evelop-pwsh

Fix spelling

df65f84

lrknox approved these changes Dec 8, 2021

View reviewed changes

lrknox merged commit 83cf2cb into HDFGroup:develop Dec 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert vds swmr test script to powershell #1245

Convert vds swmr test script to powershell #1245

byrnHDF commented Dec 1, 2021

derobins Dec 1, 2021

byrnHDF Dec 1, 2021

derobins Dec 1, 2021

byrnHDF Dec 1, 2021

derobins Dec 1, 2021

byrnHDF Dec 1, 2021

byrnHDF Dec 1, 2021

lrknox Dec 8, 2021 •

edited

Loading

lrknox Dec 8, 2021

		@@ -0,0 +1,211 @@
		# Copyright by The HDF Group.
		# Copyright by the Board of Trustees of the University of Illinois.

		@@ -0,0 +1,537 @@
		# Copyright by The HDF Group.
		# Copyright by the Board of Trustees of the University of Illinois.

Convert vds swmr test script to powershell #1245

Convert vds swmr test script to powershell #1245

Conversation

byrnHDF commented Dec 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrknox Dec 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lrknox Dec 8, 2021 •

edited

Loading