Backport H5Dchunk_iter to 1.12 branch #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
derobins
reviewed
Aug 5, 2022
src/H5VLnative_dataset.c
Outdated
| * operations, so this is a no-op. | ||
| */ | ||
| break; | ||
| } |
There was a problem hiding this comment.
The dataset wait case doesn't belong in 1.12
There was a problem hiding this comment.
Resolved in 0b97a78
We are now using H5VL_NATIVE_DATASET_CHUNK_ITER instead.
derobins
reviewed
Aug 5, 2022
src/H5VLconnector.h
Outdated
| @@ -81,7 +81,9 @@ typedef enum H5VL_dataset_get_t { | |||
| typedef enum H5VL_dataset_specific_t { | |||
| H5VL_DATASET_SET_EXTENT, /* H5Dset_extent */ | |||
| H5VL_DATASET_FLUSH, /* H5Dflush */ | |||
| H5VL_DATASET_REFRESH /* H5Drefresh */ | |||
| H5VL_DATASET_REFRESH, /* H5Drefresh */ | |||
| H5VL_DATASET_WAIT, /* H5Dwait */ | |||
There was a problem hiding this comment.
Dataset wait doesn't belong in 1.12
There was a problem hiding this comment.
Resolved in 0b97a78
We are now using H5VL_NATIVE_DATASET_CHUNK_ITER instead.
1 task
…info.c (HDFGroup#1820) The two macro schemes were not designed to work together. Also quiets some MSVC warnings about comparing pointers and integers.
…t elements, fix HDFGroup#1419 (HDFGroup#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix HDFGroup#1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist
mkitti
requested review from
jhendersonHDF,
fortnern,
soumagne,
vchoi-hdfgroup,
ChristopherHogan,
gnuoyd,
jrmainzer and
lrknox
as code owners
derobins
approved these changes
Aug 16, 2022
jhendersonHDF
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H5Dchunk_iter was reintegrated reverting #733.
Incorporates changes to
H5chunk_iterfromTo do:
xref: Backport H5Dchunk_iter to 1.10 branch #1968 (for 1.10 branch)