Fix example ref files path #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Component - Documentation
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
| @@ -726,7 +726,7 @@ FORTRAN | |||
| MATLAB PyHigh PyLow | |||
| </td> | |||
| <td>h5ex_t_vlstring.h5</td> | |||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/develop/HDF5Examples/C/H5T/tfiles/18/h5ex_t_vlstring.tst">h5ex_t_vlstring.tst</a></td> | |||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/develop/HDF5Examples/C/H5T/tfiles/16/h5ex_t_vlstring.tst">h5ex_t_vlstring.tst</a></td> | |||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/develop/HDF5Examples/C/H5T/tfiles/18/h5ex_t_vlstring.ddl">h5ex_t_vlstring.ddl</a></td> | |||
There was a problem hiding this comment.
Why use different versions of things in all these different places? Such as 16 for the .tst file and 18 for the .ddl file?
There was a problem hiding this comment.
Because there is a difference between versions for results: 114 needs to point to the correct files. All the *.tst files are the same since 1.6. DDLs are almost the same since 1.8, references are the same since 112. And of course your change for VLEN is since 1.14.
jhendersonHDF
approved these changes
Mar 29, 2024
lrknox
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.