Minor refactoring of testframe.c testing framework #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
added
Merge - To 1.14
Priority - 3. Low 🔽
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
A few minor follow-on changes from comments in #4891 |
jhendersonHDF
commented
Oct 4, 2024
| PerformTests(void) | ||
| { | ||
| for (unsigned Loop = 0; Loop < TestCount; Loop++) { | ||
| int old_num_errs = TestNumErrs_g; | ||
|
|
||
| if (TestArray[Loop].TestSkipFlag) { | ||
| if (TestFrameworkProcessID_g == 0) | ||
| MESSAGE(2, ("Skipping -- %s (%s) \n", TestArray[Loop].Description, TestArray[Loop].Name)); | ||
| MESSAGE(2, ("Skipping -- %s (%s) \n", TestArray[Loop].Description, TestArray[Loop].Name)); |
There was a problem hiding this comment.
The MESSAGE macro includes the check for TestFrameworkProcessID_g of 0
jhendersonHDF
commented
Oct 4, 2024
| * Perform test cleanup | ||
| */ | ||
| void | ||
| TestCleanup(void) |
There was a problem hiding this comment.
TestCleanup() was only used in a few places and is covered entirely by PerformTests() now
jhendersonHDF
commented
Oct 4, 2024
| @@ -180,15 +197,16 @@ extern "C" { | |||
| * | |||
| */ | |||
| H5TEST_DLL herr_t TestInit(const char *ProgName, void (*TestPrivateUsage)(FILE *stream), | |||
| int (*TestPrivateParser)(int argc, char *argv[]), int TestProcessID); | |||
| int (*TestPrivateParser)(int argc, char *argv[]), herr_t (*TestSetupFunc)(void), | |||
There was a problem hiding this comment.
Added a run-once setup and cleanup callback for the whole test program. The setup callback is called as part of TestInit() to initialize state as soon as possible and the cleanup callback is called by TestShutdown() to keep the state around as long as possible (for test post-processing or similar).
jhendersonHDF
force-pushed
the
feature/test_framework_refactor
branch
from
d3a27ff to
cfb0ae9
Compare
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
byrnHDF
approved these changes
Oct 7, 2024
mattjala
approved these changes
Oct 7, 2024
bmribler
approved these changes
Oct 7, 2024
qkoziol
approved these changes
Oct 7, 2024
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Oct 9, 2024
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
lrknox
pushed a commit
that referenced
this pull request
Oct 10, 2024
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Oct 10, 2024
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
lrknox
pushed a commit
that referenced
this pull request
Oct 11, 2024
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
jhendersonHDF
added a commit
to LifeboatLLC/hdf5_lifeboat
that referenced
this pull request
Dec 24, 2024
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program Removed TestCleanup() function since its functionality is covered by PerformTests() Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setup and cleanup callback parameters to TestInit() to perform setup and cleanup tasks once for whole test program
Removed TestCleanup() function since its functionality is covered by PerformTests()
Added check of the HDF5_NOCLEANUP environment variable in GetTestCleanup()