Update clang-format to 17 #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bump the clang-format GitHub actions to 17
derobins
added
Merge - To 1.14
Priority - 2. Medium ⏹
derobins
requested review from
jhendersonHDF,
byrnHDF,
brtnfld,
epourmal,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
|
fwiw, I would probably not cherry pick this directly to 1.14 and 1.16. I would just update the GitHub actions to use v17 and then simply reformat the source and commit that. |
|
I checked out all the options that were added in clang-format 14-17 and there wasn't anything I thought made a useful difference. I also tried pulling all the clang-format comments to see if we could ditch them. Only a few were unnecessary and they've been removed in this PR. |
derobins
added
Type - Task
|
One thing I've noticed is that my Ubuntu 23.10 VM uses 17.0.2 while the action uses 17.0.4 and there are minor differences in the output. Not sure if anyone cares about that. |
qkoziol
approved these changes
Oct 5, 2024
hyoklee
approved these changes
Oct 5, 2024
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Oct 9, 2024
Also bump the clang-format GitHub actions to 17
lrknox
pushed a commit
that referenced
this pull request
Oct 10, 2024
Also bump the clang-format GitHub actions to 17
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Oct 10, 2024
Also bump the clang-format GitHub actions to 17
lrknox
added a commit
that referenced
this pull request
Oct 10, 2024
* Correct publish path * Update clang-format to 17 (#4931) Also bump the clang-format GitHub actions to 17 * Committing clang-format changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format 13 is getting old. This updates the repository to 17.
Formatting changes are minimal. A few unnecessary
clang-format off/onlineswere removed, but no new options have been added to .clang-format.