Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken link in release process #5144

Closed
wants to merge 1 commit into from
Closed

Fix a broken link in release process #5144

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Nov 24, 2024

snapshot-2.0.0 tag doesn't exist.

@hyoklee hyoklee added the Component - Documentation Doxygen, markdown, etc. label Nov 24, 2024
derobins
derobins requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@derobins derobins left a comment •
edited by hyoklee
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we referring to a tag for a release that will never exist?

@hyoklee
Copy link
Member Author

hyoklee commented Nov 25, 2024

Why are we referring to a tag for a release that will never exist?

I just want to make this CI pass: https://github.com/HDFGroup/hdf5/actions/runs/11986265289/job/33419127227

byrnHDF
byrnHDF requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment •
edited by hyoklee
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release process doc is for future releases - therefore by definition this will fail.
The text needs to be changed that isn't parsed as a link but indicates what it should be.

@hyoklee hyoklee closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@derobins derobins derobins requested changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Documentation Doxygen, markdown, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyoklee @derobins @byrnHDF