Convert Library Version html to doxygen #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
bmribler
reviewed
Dec 2, 2024
| @@ -26,7 +26,264 @@ | |||
|
|
|||
| /** \page RELVERSION HDF5 Library Release Version Numbers | |||
|
|
|||
| \htmlinclude LibraryReleaseVersionNumbers.html | |||
There was a problem hiding this comment.
Shouldn't this be in a separate dox file?
There was a problem hiding this comment.
It was short enough to be here.
mattjala
reviewed
Dec 9, 2024
mattjala
previously approved these changes
Dec 9, 2024
lrknox
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
The text will need more thoughtful review before release.
- I don't think the major/minor/release difference between the 1.x releases and the 2.x releases is sufficiently clear.
- I think we changed H5check behavior at some point. We should verify that the sections around line 170 accurately describe current behavior.
mattjala
approved these changes
Dec 12, 2024
byrnHDF
added a commit
to byrnHDF/hdf5
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.