Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no need to request libcurses for the CMake CI #5180

Merged
merged 6 commits into from
Dec 18, 2024
Merged

There is no need to request libcurses for the CMake CI #5180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ba0479
remove unnecessary libncurses5 dependency
byrnHDF Dec 16, 2024
931c7d8
Correct compiler env vars
byrnHDF Dec 16, 2024
3cb4462
Update .github/workflows/cmake-ctest.yml
byrnHDF Dec 17, 2024
8d705d5
Merge branch 'HDFGroup:develop' into develop-ci-clang
byrnHDF Dec 17, 2024
fdbe091
Do not use CXX env var for intel builds
byrnHDF Dec 17, 2024
ee059c9
Merge branch 'HDFGroup:develop' into develop-ci-clang
byrnHDF Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cmake-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Install CMake Dependencies (Linux_coverage)
run: |
sudo apt update
sudo apt-get install ninja-build doxygen graphviz curl libncurses5 build-essential
sudo apt-get install ninja-build doxygen graphviz curl build-essential
sudo apt install libssl3 libssl-dev libcurl4 libcurl4-openssl-dev
sudo apt-get install lcov -q -y

Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
- name: Install CMake Dependencies (Linux_Leak)
run: |
sudo apt update
sudo apt-get install ninja-build doxygen graphviz curl libncurses5
sudo apt-get install ninja-build doxygen graphviz curl

- name: add clang to env
uses: KyleMayes/install-llvm-action@v2.0.5
Expand Down Expand Up @@ -227,7 +227,7 @@ jobs:
- name: Install CMake Dependencies (Linux_Address)
run: |
sudo apt update
sudo apt-get install ninja-build doxygen graphviz curl libncurses5
sudo apt-get install ninja-build doxygen graphviz curl

- name: add clang to env
uses: KyleMayes/install-llvm-action@v2.0.5
Expand Down Expand Up @@ -327,7 +327,7 @@ jobs:
- name: Install CMake Dependencies (Linux_UndefinedBehavior)
run: |
sudo apt update
sudo apt-get install ninja-build doxygen graphviz curl libncurses5
sudo apt-get install ninja-build doxygen graphviz curl

- name: add clang to env
uses: KyleMayes/install-llvm-action@v2.0.5
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/cmake-ctest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}

BINSIGN: ${{ needs.check-secret.outputs.sign-state }}
SIGNTOOLDIR: ${{ github.workspace }}/Microsoft.Windows.SDK.BuildTools/bin/10.0.22621.0/x64
run: |
Expand Down Expand Up @@ -796,7 +796,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
cd "${{ runner.workspace }}/hdf5/${{ steps.set-file-base.outputs.SOURCE_BASE }}"
cmake --workflow --preset=${{ inputs.preset_name }}-Intel --fresh
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/cmake-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cc }}
run: |
cd "${{ runner.workspace }}/hdf5"
ctest -S HDF5config.cmake,CTEST_SITE_EXT=GH-${{ github.event.repository.full_name }}-Intel,LOCAL_SUBMIT=ON,NINJA=TRUE,BUILD_GENERATOR=VS202264,CTEST_SOURCE_NAME=${{ steps.set-file-base.outputs.SOURCE_BASE }} -C Release -VV -O hdf5.log
Expand Down Expand Up @@ -597,7 +596,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
cd "${{ runner.workspace }}/hdf5"
ctest -S HDF5config.cmake,CTEST_SITE_EXT=GH-${{ github.event.repository.full_name }}-Intel,LOCAL_SUBMIT=ON,NINJA=TRUE,BUILD_GENERATOR=Unix,CTEST_SOURCE_NAME=${{ steps.set-file-base.outputs.SOURCE_BASE }} -C Release -VV -O hdf5.log
Expand All @@ -622,7 +620,7 @@ jobs:
- name: Install CMake Dependencies (Linux_clang)
run: |
sudo apt-get update
sudo apt-get install ninja-build doxygen graphviz curl libncurses5
sudo apt-get install ninja-build doxygen graphviz curl

- name: add clang to env
uses: KyleMayes/install-llvm-action@v2.0.5
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/intel-auto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
sh ./autogen.sh
mkdir "${{ runner.workspace }}/build"
Expand All @@ -54,7 +53,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
make -j3
working-directory: ${{ runner.workspace }}/build
Expand All @@ -64,7 +62,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
make check -j2
working-directory: ${{ runner.workspace }}/build
Expand All @@ -74,7 +71,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
make install
working-directory: ${{ runner.workspace }}/build
Expand All @@ -84,7 +80,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
make check-install
working-directory: ${{ runner.workspace }}/build
6 changes: 0 additions & 6 deletions .github/workflows/intel-cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
mkdir "${{ runner.workspace }}/build"
cd "${{ runner.workspace }}/build"
Expand All @@ -56,7 +55,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
cmake --build . --parallel 3 --config ${{ inputs.build_mode }}
working-directory: ${{ runner.workspace }}/build
Expand All @@ -66,7 +64,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V
working-directory: ${{ runner.workspace }}/build
Expand All @@ -93,7 +90,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
mkdir "${{ runner.workspace }}/build"
Set-Location -Path "${{ runner.workspace }}\\build"
Expand All @@ -104,7 +100,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
cmake --build . --parallel 3 --config ${{ inputs.build_mode }}
working-directory: ${{ runner.workspace }}/build
Expand All @@ -114,7 +109,6 @@ jobs:
env:
FC: ${{ steps.setup-fortran.outputs.fc }}
CC: ${{ steps.setup-fortran.outputs.cc }}
CXX: ${{ steps.setup-fortran.outputs.cxx }}
run: |
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V -E tfloatsattrs
working-directory: ${{ runner.workspace }}/build
Loading