Rework Fortran configure to allow multiple CMake reruns #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bljhdf,
derobins,
lrknox and
qkoziol
as code owners
byrnHDF
commented
Jun 3, 2021
| # The provided CMake C macros don't provide a general compile/run function | ||
| # so this one is used. | ||
| #----------------------------------------------------------------------------- | ||
| macro (C_RUN FUNCTION_NAME SOURCE_CODE RETURN_VAR) |
There was a problem hiding this comment.
This macro and tests moved from HDF5UseFortran.cmake
byrnHDF
commented
Jun 3, 2021
config/cmake/HDF5UseFortran.cmake
Outdated
| @@ -129,74 +129,12 @@ endif () | |||
| # Determine the available KINDs for REALs and INTEGERs | |||
| #----------------------------------------------------------------------------- | |||
|
|
|||
| #READ_SOURCE ("PROGRAM FC_AVAIL_KINDS" "END PROGRAM FC_AVAIL_KINDS" SOURCE_CODE) | |||
| set (PROG_SRC_CODE | |||
byrnHDF
commented
Jun 3, 2021
config/cmake/HDF5UseFortran.cmake
Outdated
| @@ -271,7 +209,7 @@ foreach (KIND ${VAR}) | |||
| else () | |||
| FORTRAN_RUN("INTEGER KIND SIZEOF" ${PROG_SRC_${KIND}} XX YY VALIDINTKINDS_RESULT_${KIND}) | |||
| endif () | |||
| file (READ "${RUN_OUTPUT_PATH_DEFAULT}/pac_validIntKinds.out" PROG_OUTPUT1) | |||
| file (READ "${RUN_OUTPUT_PATH_DEFAULT}/pac_validIntKinds.${KIND}.out" PROG_OUTPUT1) | |||
There was a problem hiding this comment.
Do not reuse output files, reruns of config will not rerun successful tests.
ccmake runs iteratively, and the check_fortran_source_runs macros were clobbering a single output file that did not get updated on further configure iterations
byrnHDF
requested review from
fortnern,
jhendersonHDF,
jrmainzer,
soumagne and
vchoi-hdfgroup
as code owners
lrknox
approved these changes
Jun 7, 2021
derobins
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.