Implement fill value tests #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol_dataset_test.c
Outdated
| for (size_t i = 0; i < num_elems; i++) { | ||
| val = (double *)(read_buf) + i; | ||
|
|
||
| if (*(double *)val != DATASET_FILL_VALUE_TEST_DOUBLE_FILL_VALUE) { |
There was a problem hiding this comment.
Instead of directly comparing double values for equality, you should use something similar to the H5_DBL_ABS_EQUAL or H5_DBL_REL_EQUAL macros from the library.
mattjala
force-pushed
the
fill_value_tests
branch
from
0898041 to
896f91b
Compare
jhendersonHDF
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only tests that fill values work for integers, doubles, and fixed-length strings with ASCII characters, since not all VOLs support more complex datatypes.