Issue #63 #69
Merged
Issue #63 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for keyerror when no modules are given with an absolute path to a self compiled executable. Longbow will assume the user knows what they are doing if they are able to compile software. If modules are required such as intel etc then these should be given by the user in a job config file. This should have also fixed a related but slightly different and unreported bug with the use of environment variables. Had a user given an executable that didn't have a longbow plugin (ie a generic one) along with no modules, this would also have given an error, even though they might have configured the HPC user account with environment vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for keyerror when no modules are given with an absolute path to a
self compiled executable. Longbow will assume the user knows what they
are doing if they are able to compile software. If modules are required
such as intel etc then these should be given by the user in a job config
file.
This should have also fixed a related but slightly different and
unreported bug with the use of environment variables. Had a user given
an executable that didn't have a longbow plugin (ie a generic one) along
with no modules, this would also have given an error, even though they
might have configured the HPC user account with environment vars.