Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add switch theme drop down menu #26

Merged
merged 4 commits into from
Apr 28, 2021
Merged

[FEATURE] Add switch theme drop down menu #26

merged 4 commits into from
Apr 28, 2021

Conversation

HEIGE-PCloud
Copy link
Owner

  • Add a button for a select list to select different color theme
  • Add a option to change between select and switch in config.toml

@HEIGE-PCloud
feat: Add switch theme drop down menu preview
f5911f8 
- Add a button for a select list to select different color theme
- TODO: Add a option to change between select and switch in config.toml
@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Apr 27, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.11 milestone Apr 27, 2021
@HEIGE-PCloud HEIGE-PCloud self-assigned this Apr 27, 2021
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 27, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9204d35
Status: ✅  Deploy successful!
Preview URL: https://ba3cf371.hugodoit.pages.dev

View logs

@HEIGE-PCloud HEIGE-PCloud linked an issue Apr 27, 2021 that may be closed by this pull request
[FEATURE] Switch Theme Drop-down menu #2
Closed
@HEIGE-PCloud
feat: Add theme change mode config
9568d03 
- Change class tag and related CSS file
- Move inline js code to theme.js
- Add event update for select theme
- Add config option in config.toml
- Add switch theme button for mobile view
- Add documentation for switch theme option
HEIGE-PCloud
HEIGE-PCloud commented Apr 28, 2021
View reviewed changes
layouts/partials/header.html Outdated Show resolved Hide resolved
layouts/partials/header.html Outdated Show resolved Hide resolved
@HEIGE-PCloud HEIGE-PCloud marked this pull request as ready for review April 28, 2021 12:22
@HEIGE-PCloud HEIGE-PCloud merged commit 83e5278 into main Apr 28, 2021
@HEIGE-PCloud HEIGE-PCloud deleted the dev/switch-theme-menu branch April 28, 2021 12:27
@HEIGE-PCloud
Copy link
Owner Author

Notice that outdated cache may cause issue when enable the themeChangeMode for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpongeBab SpongeBab SpongeBab approved these changes

Assignees

@HEIGE-PCloud HEIGE-PCloud

Labels
enhancement Enhance existing features
Projects
None yet
Milestone
v0.2.11
Development

Successfully merging this pull request may close these issues.

[FEATURE] Switch Theme Drop-down menu
2 participants
@HEIGE-PCloud @SpongeBab